Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: emulate bash key bindings

[sorry for the late answer]

Roman Perepelitsa wrote on Thu, Jan 09, 2020 at 12:03:16 +0100:
> On Wed, Jan 8, 2020 at 11:25 PM Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> > That's true for z-sy-h's master branch, but with the feature/redrawhook
> > branch (due to be merged after 0.7.0's release) highlighting will be
> > refreshed even by invocations of dot-prefixed widgets.
> [cc:ericdfreese@xxxxxxxxx]
> That's useful to know. Thanks for the heads up.
> I took a look at the code and see that feature/redrawhook branch
> applies highlighting in zle-line-pre-redraw. Won't this cause issues
> when zsh-syntax-highlighting is used together with
> zsh-autosuggestions?

Yes, such issues were reported, last confirmed 4 days ago:


> zsh-autosuggestions doesn't wrap zle-line-pre-redraw by default, so it won't
> apply its own highlighting on top of zsh-syntax-highlighting.

Okay, and what could z-sy-h do about this?  The redrawhook branch fixes a *lot*
of bugs, so I'm not eager to make it optional.  I suppose I could just tell
people who use both plugins to stick to z-sy-h 0.7.0 (as opposed to master)
until there's a z-asug release that uses «add-zle-hook-widget
zle-line-pre-redraw» too — or is there a better solution that I'm overlooking?

> If zsh-autosuggestions starts wrapping zle-line-pre-redraw by default, there
> are still potential issues for users who upgrade their local
> zsh-syntax-highlighting before zsh-autosuggestions.

I'm not overly concerned about this.  Anyone who uses z-sy-h from master should
_expect_ to live on the bleeding edge.  Anyone who's not ready to live on the
bleeding edge should stick to tags (or, at least, follow master with an N days'
delay, so any issues will be ironed out before they get to it).

> There are also users who manually set ZSH_AUTOSUGGEST_IGNORE_WIDGETS.

And how does this affect z-sy-h?



Messages sorted by: Reverse Date, Date, Thread, Author