Re: git-completion 1.2 released

[Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>]

Felipe Contreras wrote on Sat, Nov 21, 2020 at 18:53:56 -0600:
> On Sat, Nov 21, 2020 at 10:05 AM Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > Felipe Contreras wrote on Thu, 19 Nov 2020 16:05 +00:00:
> > > Git-completion is a friendly fork of the official Git completion and
> > > prompt scripts for Zsh and Bash.
> > >
> > > The main goal is to provide a more up-to-date completion for Zsh (I'm
> > > the developer), which is basically just a wrapper around the Bash
> > > completion.
> >
> > I was going to invite you to send patches to zsh's own _git, but then I
> > noticed that in README.asciidoc you claim that you've sent patches to
> > zsh's completion and "many" of them have been "ignored":
> 
> Git's zsh completion, not Zsh's Git completion.

Thanks for clarifying this.

> > > Compared to Git upstream, you get many benefits for Zsh, for example:
> > > no extra unnecessary spaces, correct auto suffix removal, colors
> > > without PROMPT_COMMAND, custom aliases, fixed --no-options, and many
> > > more.
> >
> > I suspect some of these have been fixed in zsh's _git since you last
> > looked and others are configurable.  (E.g., git-send-email(1), which you
> > mention below, completes not only files but also recent commits, and has
> > done so for a while.)
> 
> But the main use of "git send-email" is not to receive random files,
> it's to receive comittishes, and potentially some .patch files.
> 

So, just this?  Will anyone want to complete files that _don't_ have
a .patch extension?

diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
index 81a060e4d..8d1567e39 100644
--- a/Completion/Unix/Command/_git
+++ b/Completion/Unix/Command/_git
@@ -4443,7 +4443,7 @@ _git-send-email () {
     '--force[send emails even if safety checks would prevent it]' \
     '(- *)--dump-aliases[dump configured aliases and exit]' \
     '*: : _alternative -O expl
-      "files:file:_files"
+      "files:file:_files -g \"*.patch\""
       "commits:recent commit object name:__git_commit_objects_prefer_recent"'
 }
 

> If I do "git send-email master..<tab>" nothing completes with Zsh's
> official completion. It does with mine.

Thanks for the bug report.