Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: completion ( compctl ) does not trigger for command names containing dashes

> Den ons 3 maj 2023 kl 19:13 skrev Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>:
> On Wed, May 3, 2023 at 2:59 AM Fredrik Ax <fredrik@xxxxxxxx> wrote:
> >
> > zshprompt% compctl -k '(arg1 arg2 arg3)' with-dash
> >
> > # typing 'with-dash ' and hitting [Tab] once:
> > zshprompt% with-dash
> > file2.txt    myfile1.txt
> This dates back to the tokenization of hyphens to fix bugs in [a-z]
> types of patterns.  The ancient code in compctl is using the raw
> command string and therefore looking for completions for
> $'with\233-dash' rather than 'with-dash'.
>  See if this (attached) fixes it without breaking anything else.


I made a quilt patch of this for the debian zsh_5.9-4 source package, rebuilt and installed it ... it seems to be working fine. No build or install issues, commands-with-dashes-in-the-name are now matched by the compctl rules ... looking good.

Will keep running it for a while to see if I get anything else breaking by it.
Can you give some pointers of which areas might get affected by this change, what to look for?

Once, I'm satisfied it works well without breaking other stuff, how do I best submit this for upstream inclusion?

Again, thanks in advance

Messages sorted by: Reverse Date, Date, Thread, Author