Re: PATCH: Re: 4.0.1-pre-1

["Bart Schaefer" <schaefer@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mar 6,  1:57pm, Sven Wischnowsky wrote:
} Subject: PATCH: Re: 4.0.1-pre-1
}
} The patch below changes the code in parse.c to use real memory for the 
} `ecbuf'. It would be very nice if we could avoid that and instead
} write a better hrealloc(), but that's non-trivial to say the least.
} 
} I think I got the freeing right, but I'd be thankful if someone with 
} an allocation profiler could verify that.

It runs "make check" correctly when linked with ElectricFence, but I
don't believe that detects memory leaks, only memory under/over-runs.

However, with the latest CVS this morning, I'm getting a failure in
54compmatch:

*** /tmp/zsh.ztst.out.22091     Tue Mar  6 07:31:47 2001
--- /tmp/zsh.ztst.tout.22091    Tue Mar  6 07:31:48 2001
***************
*** 1,3 ****
! line: {tst .:}{}
  COMPADD:{}
  INSERT_POSITIONS:{4:5:6}
--- 1,3 ----
! line: {tst }{.:}
  COMPADD:{}
  INSERT_POSITIONS:{4:5:6}
Test ../../zsh-3.1.6/Test/54compmatch.ztst failed: output differs from expected as shown above for:
 workers_11388_matcher='r:|[:.]=** r:|=*'
 workers_11388_list=(a.b:0 c.d:1)
 test_code $workers_11388_matcher workers_11388_list
 comptest $'tst :\t'
Was testing: Non-bug from workers 11388
../../zsh-3.1.6/Test/54compmatch.ztst: test failed.


(This reminds me again that we'd discussed renumbering the test suite to
group similar tests together and perform them in vaguely dependency order.
Are we going to get to that and to re-organizing Completion/ before PWS
decides to shove 4.0.1 out the door?)

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net