Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: signed chars without multibyte support

X-seq: zsh-workers 23074
From: Wayne Davison <wayned@xxxxxxxxxxxxxxxxxxxxx>
To: Peter Stephenson <pws@xxxxxxx>
Subject: Re: PATCH: signed chars without multibyte support
Date: Tue, 19 Dec 2006 12:37:37 -0800
Cc: Zsh hackers list <zsh-workers@xxxxxxxxxx>
In-reply-to: <200612191255.kBJCtcvQ003165@xxxxxxxxxxxxxx>
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
References: <200612191255.kBJCtcvQ003165@xxxxxxxxxxxxxx>

On Tue, Dec 19, 2006 at 12:55:38PM +0000, Peter Stephenson wrote:
> +	    *c = x[1] ^ 32;
[...]
> +	*c = (char)*x;

I don't really like this, as it means that the int value returned can be
a -1 (EOF) when *x is 0xFF.  It would be better to change the code that
is comparing a char against an int to use STOUC() on the char value in
the comparison.

..wayne..

Follow-Ups:
- Re: PATCH: signed chars without multibyte support
  - From: Peter Stephenson

References:
- PATCH: signed chars without multibyte support
  - From: Peter Stephenson

Messages sorted by: Reverse Date, Date, Thread, Author