Re: [PATCH] compdescribe fix for unsorted groups (workers/34814) (was: Re: completion: git: --fixup: problem with _describe -2V and duplicate commit subjects)

[Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>]

On May 19,  1:36am, Daniel Shahaf wrote:
} Subject: Re: [PATCH] compdescribe fix for unsorted groups (workers/34814) 
}
} You tried to complete 'git checkout 1<TAB>'.  The bug reproduces when
} I do 'git checkout <TAB>', i.e., space-tab, not space-digitone-tab.

OK; I was just trying to repeat what you said in 35127:
> I apply the first patch, Daniel Hahler's recent series, and the second
> attached patch, and then try to complete 'git checkout 1<TAB>',¹ I get
> first a screenful of hashes, and then a screenful of descriptions, and

I now realize that you don't mean "a screenful of ######" but rather a
screenful of git checksums.  I've been looking all this time for some
sort of horrible memory scrambling that was filling your screen with
garbage.  Sigh.

So ... 35127 deletes/disregards this comment:

-    # Note: the after-the-colon part must be unique across the entire array;
-    # see workers/34768

It then proceeds to add two completions for each description.  The problem
described in 34768 kicks in, and you get the results you observed.

If I modify the _git hunk in 35127 to force one $k part of each pair of
_descr+=(...) assignments to differ, everything works as desired, except
that there are still another duplicate set of everything from 35101.

} I haven't noticed this before, but after pressing space and tab I get
} a "zsh: do you wish to see all 140 possibilities (124 lines)?" prompt
} that I answer 'y' to.  The figure 140 is because there are 100
} completions and 40 descriptions; that is, the descriptions are counted
} towards the total number of offered completions.  Why would descriptions
} be counted towards the total number of completions?

Side-effect of the problem discussed in 34768, and a clue if we'd noted
it sooner.

I think it's up to you to figure out how to make 34671 work with 35127,
as they are both your patches.