Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: zsh-5.2-test-3

Bart Schaefer wrote on Sat, Dec 10, 2016 at 19:07:37 -0800:
> +++ b/Src/Zle/compmatch.c
> @@ -674,7 +674,7 @@ match_str(char *l, char *w, Brinfo *bpp, int bc, int *rwlp,
>  		     *
>  		     * operation.  Similar to savw.
>  		     */
> -		    char savl;
> +		    char savl = 0;

I see you've pushed this, but for what it's worth, it wouldn't have been
my first choice.  I'd rather have left the variable uninitialized in the
(sfx is false) case, precisely so reading savl without checking sfx
first would result in an "is used uninitialized" warning.
Messages sorted by: Reverse Date, Date, Thread, Author