Zsh Mailing List Archive
Messages sorted by:
Re: Error in zshaddhistory() should not prevent command from running
- X-seq: zsh-workers 40257
- From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: Re: Error in zshaddhistory() should not prevent command from running
- Date: Mon, 2 Jan 2017 02:48:00 +0000
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=f+nW3HtA2+leHY2 WrcKWNIVP+1w=; b=ZkB91e5Ifa1JyL83AmL/u9qHug0ZfBGNPEsUxyr4g4gbxr/ 1pDqlxD19AsXP54ZfwJ6S5QpYrZbz1qDNKzXQ6Tp0ziooEetSi3JjyVGSyMc5K0H yT5EGakR9WHumRXhjxh3USMKSTQbU/Y2xjShJhuUldHzQgTyZ1hKPUs9LBCM=
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=f+nW3HtA2+leHY 2WrcKWNIVP+1w=; b=NIGThpxdlZY8kDRb4gTNpNO2fE+c/cB/QnEdXaG32kOtB0 SMQVJUGMuWGXQvqA0eP04vRDK91ibslV7tahNifkcZabe4FPp+iEPzIBuRvbf41r 7thWNsaubvq5ACArdDwAQCalmrpc3G3UtDvyGVzABu6HvHiHSPEEmCeHnn21E=
- In-reply-to: <170101112030.ZM28010@torch.brasslantern.com>
- List-help: <mailto:email@example.com>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:firstname.lastname@example.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <alpine.LRH.email@example.com> <20170101031034.GA15639@fujitsu.shahaf.local2> <170101112030.ZM28010@torch.brasslantern.com>
Bart Schaefer wrote on Sun, Jan 01, 2017 at 11:20:30 -0800:
> On Jan 1, 3:10am, Daniel Shahaf wrote:
> } Subject: Re: Error in zshaddhistory() should not prevent command from runn
> } > Possibly more controversial, why run this hook at all when nothing is
> } > being added?
> } 2) It's easier to call the user-provided hook function on one more case
> } that it can easily ignore, than not to do so and to leave the user with
> } no easy alternative.
> As far as I can tell the only case where *chline == '\0' is when the EOF
> character has been typed -- there's always at least a newline in there
> in all other circumstances.
I'd assumed we were talking about empty lines (i.e., <accept-line> when
BUFFER=''). My bad. I don't have an opinion on whether zshaddhistory()
should be called during the EOF processing sequence.
> There are lots of other places to add to
> the history on shell exit. But this is why I asked -- other opinions?
Messages sorted by: