Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: "set -e" handling is broken with zsh 5.3.1 and 5.4.1



On Sun, Aug 27, 2017 at 6:25 PM, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> Vincent Lefevre wrote on Mon, 28 Aug 2017 00:26 +0200:
>> Perhaps it was needed in the past, and no longer makes sense now.
>> Have you looked at the diff that introduced it,
>
> It's this one:
>
> commit d6a32ddeed914434f5b56b013c9d03b28781d065
> Author: Barton E. Schaefer <schaefer@xxxxxxx>
> Date:   Sat Dec 27 21:55:58 2014 -0800
>
>     34065: following an "if" condition, do not test lastval for ERR_EXIT until a new command is run


Background is in workers/34055 and 34059, and this looks to have
something to do with noerrexit not propagating into the first sublist
in a function body.  It's entirely possible that the change from
having a few numeric values for the flags to have a set of bit values
has made that test unnecessary, or it may be needed in case that
hasn't been tested yet -- the original report in 34055 involves
calling a function within an if/else block.



Messages sorted by: Reverse Date, Date, Thread, Author