Zsh Mailing List Archive
Messages sorted by:
Re: PATCH: completion match ordering
- X-seq: zsh-workers 44278
- From: Oliver Kiddle <okiddle@xxxxxxxxxxx>
- To: dana <dana@xxxxxxx>, Zsh workers <zsh-workers@xxxxxxx>
- Subject: Re: PATCH: completion match ordering
- Date: Tue, 07 May 2019 14:39:20 +0200
- Authentication-results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=yahoo.co.uk
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1557232763; bh=3GJb5WEj84XQWIFoDb0WN+fsCytNYuhfMg0S9Tt/vPY=; h=From:References:To:Subject:Date:From:Subject; b=CrGX/aUWd9W+rlQeYGxfQazVY2Ybi3IrijLgVMRhKoohQKF2yneVsGFMZc2yMv25isay9lJNezd5wEgZ1NAxkUWKdJOtd5blCq5KkeZ1Vb/IC7I0EzdBK475y2hucRK/Epa/YyVWeXn15VagcnpM1Q/nOmEGTao8GI+inswD/q6UUWhvtNG6FxDUsdZeScprMh5r43TMxEQmF+5XIslcP+uSI8HS0Qd3/DcT5WhZ4+n/KyHEPK8gy5omU74jv3eWbAzM81ycFAOV362nQ/vh5qzSTvtTB/C6jnLyTa9Ri5LkdrRKtZ9HpTC/Ja2su1cDVdB/29d4t63IuC5Il0VXEA==
- In-reply-to: <693EF72F-D53C-429F-9B0C-C44BB19AB1DB@dana.is>
- List-help: <mailto:email@example.com>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:firstname.lastname@example.org>
- List-unsubscribe: <mailto:email@example.com>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <75B26F45-E6E6-44BB-80A4-7301CBE480FE@dana.is> <88812-1541586959.338018@YaNA.ZOZt.NKaA> <76839-1543195550.251964@c6AU.RX4q.p78d> <93343-1557177371.866119@fZLB.yW79.IWgX> <693EF72F-D53C-429F-9B0C-C44BB19AB1DB@dana.is>
> Your matchcmp() update removes SORTIT_IGNORING_BACKSLASHES entirely ??? is that
> deliberate in light of my changes? It should always make sense to skip
No, not deliberate.
I picked up my old git branch for this change and hadn't really tested
together. I didn't think the patch would even apply cleanly. I'll add in
the missing bitwise OR against SORTIT_IGNORING_BACKSLASHES in the call
to zstrcmp() in matchcmp(), when committing the rest of it.
> back-slashes in completion matches unless `compadd -Q` is used to bypass
> escaping, shouldn't it? Or do i misunderstand?
That makes sense as you describe it.
Messages sorted by: