Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: _subversion is going to need to use 'help -v'

On 9/4/19, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> Daniel Shahaf wrote on Sat, 31 Aug 2019 20:19 +00:00:
>> tl;dr: A change made to Subversion (upstream) trunk today affects
>> _subversion.
> Patch attached.  I think it's fairly safe to commit it already, even
> before the upstream release: it's unlikely that «svn help -v» will be
> made to mean "grow a toaster's arm".

The "Use 'svn help -v' to show global options" patch is broken:
re-compiling /usr/local/share/zsh/5.7.1-dev-0-mika/functions.zwc:
zrecompile:41: parse error near `fi'
the resulting code is:
  if _cache_invalid svn-help-takes-verbose || ! _retrieve_cache
svn-help-takes-verbose; then
    if [[ $(_call_program svn-help-v svn help help) == *--verbose* ]]
    _svn_help_takes_verbose=$(( ! $? ))
    _store_cache svn-help-takes-verbose _svn_help_takes_verbose

which has both unclear indentation and intention. I would fix it but I
don't know if you meant to include both lines in the if. Please don't
use short_loops malformed syntax in distributed code because it always
leads to incorrectly written code like the above.

Mikael Magnusson

Messages sorted by: Reverse Date, Date, Thread, Author