Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin

> 2020/03/05 4:29, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
>> I feel just letting the test fail may be enough,  but if we are going
>> to add a new parameter/flag to ztst.zsh then it would be something like
>> the patch below.
> In this case, how about letting the test fail, as you say?  If in the
> future we change our mind about that, we can add the $ZTST_not_fatal
> flag then.

OK, If users complain that the failure is too stringent then we will make it
not fatal.

>> BTW, in B01cd.ztst, line 73:
>> #  . d  Don't diff stdout against the expected stdout.
>> What does this '.' mean?  Is it just a typo?
> It was added in 08f084ecdeaeb19e595441e3e0203be4562bd285 (no X-Seq) by
> pws.  The change isn't mentioned in the log message and broke alignment
> of the description column, so I guess it was a typo.


>> Test/B01cd.ztst    |  7 +++++--
>> Test/B12limit.ztst | 10 ++++++++++
>> Test/ztst.zsh      | 32 ++++++++++++++++++++++----------
>> 3 files changed, 37 insertions(+), 12 deletions(-)
> I reviewed the diff (without out-of-hunk contexts) and have no comments.

How about the patch for rlimit.c?
If it's OK (other than the constness and name of the structure) I will push
them soon.

Messages sorted by: Reverse Date, Date, Thread, Author