Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Enable sub-second timeout in zsystem flock



On 14 Mar 2020, at 19:50, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> I think the invalid value should be included in the error message,
> either as a number, or as a string if needed: "flock: invalid timeout
> value: '%s'".  In my experience, "invalid input" error messages are
> easier to consume when they actually say what the invalid input is.
>
> dana, I see you advocated the opposite approach in 45283.  What's your
> rationale?

I think i was just trying not to seem nit-picky in light of the fact that it
didn't previously error-check the time-out value. I agree that including the
original input in the error message would be better (and more typical)

dana



Messages sorted by: Reverse Date, Date, Thread, Author