Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: readhistfile(): do not call ftell() in loop

X-seq: zsh-workers 45779
From: Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>
To: xzfcpw@xxxxxxxxx, zsh-workers@xxxxxxx
Subject: Re: PATCH: readhistfile(): do not call ftell() in loop
Date: Mon, 4 May 2020 16:30:33 +0100 (BST)
Importance: Medium
In-reply-to: <cef5c98b3d0fb920e93d90c7cd44ce0f2da3c68d.camel@gmail.com>
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
References: <cef5c98b3d0fb920e93d90c7cd44ce0f2da3c68d.camel@gmail.com>

> On 03 May 2020 at 10:33 xzfcpw@xxxxxxxxx wrote:
> 
> 
> Prior to this patch, readhistfile() performed one lseek() syscall (inside ftell()) per each history entry.
> This is time-consuming on large histfiles.
> 
> This patch replaces this call to ftell() with manual tracking of bytes read.

Looks fine to me --- can't think of any gotchas with file position.  I'll commit if no one else
has any comments.

pws

References:
- PATCH: readhistfile(): do not call ftell() in loop
  - From: xzfcpw

Messages sorted by: Reverse Date, Date, Thread, Author