Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] [doc] clone module using xterm's slave mode

Stephane Chazelas wrote on Tue, 19 May 2020 19:54 +0100:
> 2020-05-19 01:01:40 +0000, Daniel Shahaf:
> [...]
> > There's a race condition here («clone» might run before «./pty» is
> > created).  Is it worthwhile to point it out in the text, or add
> > a «sleep» in the example?  
> [...]
> You're right, maybe a better approach would be to supply a
> contrib function for that which could be extended to other
> terminal emulators like:

I'm fairly certain that that's nothing at all like what I said :)

Anyway, to answer your question, I'd say that's up to you.  The docs
patch is perfectly good and useful as it stands.  A function would be
even better, but if that's not possible for some reason (e.g., because
of the mentioned dependency on «socat»'s debug output format), then I'd
vote for going with the docs patch.

> > By the way, WDYT of adding a concept index entry (e.g., «cindex(tty,
> > cloning the shell onto an unused)») at the top of the file?  I think the
> > existing cindex entries won't help someone who doesn't know what the
> > module is called to discover it.  
> [...]
> To be honest, I'm not sure I understand what that module is for.
> What would be a typical use case?

Not sure.



Messages sorted by: Reverse Date, Date, Thread, Author