Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: Useless assignment in _rm



Daniel Shahaf wrote on Tue, 23 Jun 2020 12:40 +0000:
> zsugabubus wrote on Mon, 22 Jun 2020 12:27 +0200:
> > diff --git a/Completion/Unix/Command/_rm b/Completion/Unix/Command/_rm
> > index ea9190d..e66b77f 100644
> > --- a/Completion/Unix/Command/_rm
> > +++ b/Completion/Unix/Command/_rm
> > @@ -69,7 +69,7 @@ _arguments -C -s -S $opts \
> > 
> >  case $state in
> >    (file)
> > -    line[CURRENT]=()
> > +    (( CURRENT > 0 )) && line[CURRENT]=()
> >      line=( ${line//(#m)[\[\]()\\*?#<>~\^\|]/\\$MATCH} )
> >      _files -F line && ret=0
> >      ;;  
> 
> Thanks; I'll commit this unless someone sees a reason not to.

Applied, thanks.

I edited your vanity plate of an email address out.  I'm afraid it
amounts to name-calling and as such has no place in official
documentation, which ChangeLog is.

Also, I forgot to say it before, thanks for auditing other uses of *::
and *:::.



Messages sorted by: Reverse Date, Date, Thread, Author