5.8: LTO exposes some new issues

[Tomasz Kłoczko <kloczko.tomasz@xxxxxxxxx>]

Hi

Looks like by using LTO is possible to expose new source code issues.
Also looks like zsh still is using  mktemp()

gcc -Wl,-z,relro -Wl,--as-needed  -Wl,-z,now
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld -flto=auto
-flto-partition=none -fuse-linker-plugin  -rdynamic -o zsh main.o  `cat
stamp-modobjs`   -lpcre -ldl -lncursesw -ltinfo -lrt -lm  -lc
hist.epro:19:18: warning: type of 'histtab' does not match original
declaration [-Wlto-type-mismatch]
   19 | extern HashTable histtab;
      |                  ^
hist.c:101:11: note: 'histtab' was previously declared here
  101 | HashTable histtab;
      |           ^
hist.c:101:11: note: code may be misoptimized unless '-fno-strict-aliasing'
is used
hashtable.epro:21:38: warning: type of 'cmdnamtab' does not match original
declaration [-Wlto-type-mismatch]
   21 | extern mod_import_variable HashTable cmdnamtab;
      |                                      ^
hashtable.c:585:22: note: 'cmdnamtab' was previously declared here
  585 | mod_export HashTable cmdnamtab;
      |                      ^
hashtable.c:585:22: note: code may be misoptimized unless
'-fno-strict-aliasing' is used
hashtable.epro:33:38: warning: type of 'aliastab' does not match original
declaration [-Wlto-type-mismatch]
   33 | extern mod_import_variable HashTable aliastab;
      |                                      ^
hashtable.c:1172:22: note: 'aliastab' was previously declared here
 1172 | mod_export HashTable aliastab;
      |                      ^
hashtable.c:1172:22: note: code may be misoptimized unless
'-fno-strict-aliasing' is used
hashtable.epro:34:38: warning: type of 'sufaliastab' does not match
original declaration [-Wlto-type-mismatch]
   34 | extern mod_import_variable HashTable sufaliastab;
      |                                      ^
hashtable.c:1177:22: note: 'sufaliastab' was previously declared here
 1177 | mod_export HashTable sufaliastab;
      |                      ^
hashtable.c:1177:22: note: code may be misoptimized unless
'-fno-strict-aliasing' is used
hashtable.epro:31:38: warning: type of 'reswdtab' does not match original
declaration [-Wlto-type-mismatch]
   31 | extern mod_import_variable HashTable reswdtab;
      |                                      ^
hashtable.c:1109:22: note: 'reswdtab' was previously declared here
 1109 | mod_export HashTable reswdtab;
      |                      ^
hashtable.c:1109:22: note: code may be misoptimized unless
'-fno-strict-aliasing' is used
hashtable.epro:25:38: warning: type of 'shfunctab' does not match original
declaration [-Wlto-type-mismatch]
   25 | extern mod_import_variable HashTable shfunctab;
      |                                      ^
hashtable.c:803:22: note: 'shfunctab' was previously declared here
  803 | mod_export HashTable shfunctab;
      |                      ^
hashtable.c:803:22: note: code may be misoptimized unless
'-fno-strict-aliasing' is used
utils.c: In function 'getkeystring':
lto1: warning: function may return address of local variable
[-Wreturn-local-addr]
utils.c:6644:16: note: declared here
 6644 |     char *buf, tmp[1];
      |                ^
/usr/bin/ld: zsh.lto.o: in function `gettempname':
/home/tkloczko/rpmbuild/BUILD/zsh-5.8/Src/utils.c:2226: warning: the use of
`mktemp' is dangerous, better use `mkstemp' or `mkdtemp'

kloczek
-- 
Tomasz Kłoczko | LinkedIn: *http://lnkd.in/FXPWxH <http://lnkd.in/FXPWxH>*