Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] declarednull: felipec's approach

On Mon, Dec 28, 2020 at 12:09 PM Felipe Contreras
<felipe.contreras@xxxxxxxxx> wrote:
>
> On Sun, Dec 27, 2020 at 4:06 PM Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> >
> > On Wed, Dec 23, 2020 at 3:47 PM Felipe Contreras
> > <felipe.contreras@xxxxxxxxx> wrote:
> > >
> > One other thing that has me scratching my head about your patch ... I
> > can't see any reason why it matters that the bit value is (1<<30), but
> > if I try, for example, overloading (1<<22) as I did for PM_DECLARED,
> > the argument lists of shell functions stop working.
>
> Because some variables have initially the flag PM_DONTIMPORT (1<<22),
> for example IFS, so it's like initially they don't have any value
> (i.e. PM_NULL).

Yes, but nothing ever looks at PM_DONTIMPORT after setting up the
parameter table, and how did the positional parameters get involved,
and why does that NOT happen on the "raw" declarednull branch?  I
guess it has to be something that's not in your diff but that's
looking for exactly the PM_NULL bit-pattern, such that omitting
PM_UNSET makes that comparison fail.
Messages sorted by: Reverse Date, Date, Thread, Author