Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

[PATCH 1/3] src: fix build warnings



  pattern.c: In function ‘patcomppiece’:
  pattern.c:1253:14: warning: ‘from’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   1253 |     zrange_t from, to;
        |              ^~~~
  utils.c: In function ‘getkeystring’:
  cc1: warning: function may return address of local variable [-Wreturn-local-addr]
  utils.c:6703:16: note: declared here
   6703 |     char *buf, tmp[1];
        |                ^~~

Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>
---
 Src/pattern.c | 2 +-
 Src/utils.c   | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/Src/pattern.c b/Src/pattern.c
index c7c2c8bea..c28f2c9fb 100644
--- a/Src/pattern.c
+++ b/Src/pattern.c
@@ -1250,7 +1250,7 @@ patcomppiece(int *flagp, int paren)
     int hash, count;
     union upat up;
     char *nptr, *str0, *ptr, *patprev;
-    zrange_t from, to;
+    zrange_t from = 0, to;
     char *charstart;
 
     flags = 0;
diff --git a/Src/utils.c b/Src/utils.c
index 5151b89a8..37ae4c854 100644
--- a/Src/utils.c
+++ b/Src/utils.c
@@ -6700,7 +6700,8 @@ ucs4toutf8(char *dest, unsigned int wval)
 mod_export char *
 getkeystring(char *s, int *len, int how, int *misc)
 {
-    char *buf, tmp[1];
+    static char tmp[1];
+    char *buf;
     char *t, *tdest = NULL, *u = NULL, *sstart = s, *tbuf = NULL;
     char svchar = '\0';
     int meta = 0, control = 0, ignoring = 0;
-- 
2.30.0





Messages sorted by: Reverse Date, Date, Thread, Author