Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH 2/2: [WIP] Efficient dedup for unsorted completions

X-seq: zsh-workers 49926
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Mikael Magnusson <mikachu@xxxxxxxxx>
Cc: Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: PATCH 2/2: [WIP] Efficient dedup for unsorted completions
Date: Wed, 30 Mar 2022 09:41:06 -0700
Archived-at: <https://zsh.org/workers/49926>
In-reply-to: <20220326014330.3050-1-mikachu@gmail.com>
List-id: <zsh-workers.zsh.org>
References: <20220326014030.2802-1-mikachu@gmail.com> <20220326014330.3050-1-mikachu@gmail.com>

On Fri, Mar 25, 2022 at 6:44 PM Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
>
> This implements my idea for sorting a temporary array and then using
> that for deduplication.

Minor nit, but after this patch I get:

compcore.c: In function ‘makearray’:
compcore.c:3289:26: warning: unused variable ‘i’ [-Wunused-variable]
 3289 |                 int dup, i, del = 0;
      |                          ^

Follow-Ups:
- Re: PATCH 2/2: [WIP] Efficient dedup for unsorted completions
  - From: Mikael Magnusson

References:
- PATCH 1/2: Fix comments for UNIQCON/ALL
  - From: Mikael Magnusson
- PATCH 2/2: [WIP] Efficient dedup for unsorted completions
  - From: Mikael Magnusson

Messages sorted by: Reverse Date, Date, Thread, Author