Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH 2/2: [WIP] Efficient dedup for unsorted completions



On 3/30/22, Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> On Fri, Mar 25, 2022 at 6:44 PM Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
>>
>> This implements my idea for sorting a temporary array and then using
>> that for deduplication.
>
> Minor nit, but after this patch I get:
>
> compcore.c: In function ‘makearray’:
> compcore.c:3289:26: warning: unused variable ‘i’ [-Wunused-variable]
>  3289 |                 int dup, i, del = 0;
>       |                          ^

i is actually used in this patch, but not in the fixed version where I
forgot to remove the declaration, thanks.

-- 
Mikael Magnusson




Messages sorted by: Reverse Date, Date, Thread, Author