Re: [PATCH] Re: Test release: 5.8.1.2-test

[Axel Beckert <abe@xxxxxxxxxxxxxxx>]

Hi again,

On Tue, Apr 12, 2022 at 07:55:14PM +0200, Axel Beckert wrote:
> 875 run-testsuite-static FAIL stderr: (eval):7: permission denied: /file
[…]
> The question is how to fix this properly. My suggestion would be to
> move "tst_dir=V14.tmp" as well as "mkdir -p -- $tst_dir" out of the
> conditional, something along these lines:
> 
> diff --git a/Test/V14system.ztst b/Test/V14system.ztst
> index 100daab08..1e683b5b9 100644
> --- a/Test/V14system.ztst
> +++ b/Test/V14system.ztst
> @@ -2,10 +2,9 @@
>  
>  %prep
>  
> -  if zmodload -s zsh/system && zmodload -s zsh/zselect; then
> -    tst_dir=V14.tmp
> -    mkdir -p -- $tst_dir
> -  else
> +  tst_dir=V14.tmp
> +  mkdir -p -- $tst_dir
> +  if ! ( zmodload -s zsh/system && zmodload -s zsh/zselect ); then
>      ZTST_unimplemented='the zsh/system and zsh/zselect modules are not available'
>    fi
>    : > $tst_dir/file # File on which to acquire flock.

Nope, that test now fails with with non-static zsh as follows:

../../Test/V14system.ztst: starting.
Running test: zsystem flock valid time arguments
Test ../../Test/V14system.ztst failed: bad status 127, expected 0 from:
  (
    zsystem flock -t 0 -i 0.000001 $tst_dir/file    &&
    zsystem flock -t 0.1 -i 0.000001 $tst_dir/file  &&
    zsystem flock -t 0.1 -i 0.0000001 $tst_dir/file &&
    zsystem flock -t 1 -i 0.000001 $tst_dir/file
  )
Error output:
(eval):2: command not found: zsystem
Was testing: zsystem flock valid time arguments
../../Test/V14system.ztst: test failed.

So I currently have no idea how to fix that properly.

		Kind regards, Axel
-- 
PGP: 2FF9CD59612616B5      /~\  Plain Text Ribbon Campaign, http://arc.pasp.de/
Mail: abe@xxxxxxxxxxxxxxx  \ /  Say No to HTML in E-Mail and Usenet
Mail+Jabber: abe@xxxxxxxxx  X
https://axel.beckert.ch/   / \  I love long mails: https://email.is-not-s.ms/