Re: Remote scp completion that can handle spaces etc. in pathnames

[Hannu Koivisto <azure@xxxxxx>]

Oliver Kiddle <okiddle@xxxxxxxxxxx> writes:

> Patch below should fix this. _ssh has changed a bit since 4.0.4 so I'm
> not sure how easy it would be to modify for that.

Thanks!  It applied to 4.0.4 just fine.  However, I needed 
an additional modification to make it work with filenames such as
``[foo bar* |'' -- * and | didn't appear at all without this
modification.  I wonder if this breaks something elsewhere?  See
the modification below, within your patch.

>> I also note that pathnames in remote commands are not completed
>> remotely, i.e. if I write ``ssh somehost ls f<tab>'', zsh completes
>> local filesystem entries beginning with f.  I wonder if this could
>> be smarter as well.
>
> It could possibly be done by somehow doing a temporary substitution of
> _path_files by _remote_files but saving the original _path_files and
> doing any other necessary fiddling would be more than a bit messy so I'm
> not going to attempt it.

Ok, I can certainly live without such a feature.

> Oliver
>
> Index: Completion/Unix/Command/_ssh
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_ssh,v
> retrieving revision 1.18
> diff -u -r1.18 _ssh
> --- Completion/Unix/Command/_ssh	7 Jan 2003 08:49:16 -0000	1.18
> +++ Completion/Unix/Command/_ssh	13 Feb 2003 14:29:21 -0000
> @@ -17,9 +17,9 @@
>      while _tags; do
>        while _next_label files expl ${suf:-remote directory}; do
>          [[ -n $suf ]] && compadd "$@" "$expl[@]" -d remdispf \
> -	    ${remdispf%[*=@|]} && ret=0 
> +	    ${(q)remdispf%[*=@|]} && ret=0 

I replaced the above line with this:

+	    ${(q)remdispf%[=@]} && ret=0 

>  	compadd ${suf:+-S/} "$@" "$expl[@]" -d remdispd \
> -	    ${remdispd%/} && ret=0
> +	    ${(q)remdispd%/} && ret=0
>        done
>        (( ret )) || return 0
>      done

-- 
Hannu