Re: Completion function for bitkeeper?

[Oliver Kiddle <okiddle@xxxxxxxxxxx>]

Danek Duvall wrote:

> Is there any reason (other than it would break code relying on the
> current behavior) not to just require someone to explicitly add $expl to
> the action, so that they can control where it goes?  You can do that now

Having $expl stuff added after the first word is exactly the behaviour
that is wanted in virtually 100% of all cases. If you do a search on
completion functions, the $expl feature is never used and the initial
space feature is very rarely used (and where it is may not have been
intentional). And, it would break existing code (and be a very boring
job to add to existing code).

However, it does seem redundant having both the initial space and
braces feature.

For '*:desc:{_foo}' style actions, this is run:

  eval "$action[@]"

and for '*:desc: _foo', this is run:

  eval "action=( $action )"
  "$action[@]"

Can anyone tell me what practical difference that makes, if any?

What might be a good plan is to deprecate the initial space feature and
then, by only documenting expl under the {eval-string} form of action,
it will be easier make things clear in the documentation.

> > How's that bitkeeper function doing these days by the way? Is it at a
> > stage we could include with zsh? Does it conflict with _sccs?
> 
> Well, none of the usual zsh folks commented on it, so while it works for

I suspect none of the usual zsh folks use bitkeeper.

>   - there are a number of comments in the function that indicate things
>     I couldn't quite figure out what to do

If you send me your latest version, I'll take a look.

>   - I don't think that it conflicts with _sccs at all, but it might be
>     nice to get _sccs to use _sccsfiles in the appropriate places.

I'll be interested to see if that does anything useful for sccs. I use
Sun teamware at work which is sccs underneath so I do use the sccs
completion.

Oliver

________________________________________________________________________
This email has been scanned for all viruses by the MessageLabs Email
Security System. For more information on a proactive email security
service working around the clock, around the globe, visit
http://www.messagelabs.com
________________________________________________________________________