Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: test patches

Some remarks on the 3.0.3-test5 patch:

The FAQ diff isn't included.  No biggie, but people should be aware that
they'll still have last December's FAQ if all they do is patch.

I'm curious:  What's the point of removing functions like setcurjob()
and inlining their code in the function that calls them?  We're surely
not all that worried about function call overhead, and it seems to me
that it makes future changes more difficult (or at least potentially
larger diffs).  Even if the function is only called in one place, it's
preferable to work towards small, single-purpose functions, isn't it?
(It also makes stack traces without full debugging symbols easier to
interpret.)  [setcurjob happened a while ago, but I just noticed it.]

There still doesn't appear to be a test in init.c for the case where
the system supports TIOCGWINSZ but the rows and columns value in the
shttyinfo.winsize structure are both zero.  In that case we ought to
be using the row and column sizes from the termcap or terminfo entry?

Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts        http://www.nbn.com/people/lantern

Messages sorted by: Reverse Date, Date, Thread, Author