Re: make check problem

[Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>]

On Jan 22,  9:38am, Ray Andrews wrote:
}
} Nope.  I wonder why 'make check' indicates a fault when the test can't 
} possibly succeed from the getgo without that option?

I've said before that "not available" is not a "fault."  You're reading
way too much into "make check" skipping a test.

} Are there other 
} modules that require that sort of special handling?  Why is it special? 

Sorry I forgot about --enable-pcre before.  You shouldn't link=static
the zsh/pcre module without having used --enable-pcre in configure.

It's special because it's extremely non-standard and changes the meaning
of the expressions on the right-hand-side of the =~ comparison, so if
unknowingly enabled it might break scripts.

} Do I need it anyway?

You only need it if you want to use it.

} Error output:
} (eval):1: command not found: pcre_compile
} (eval):2: command not found: pcre_match
} (eval):10: command not found: pcre_study

Hmm, sorry, my patch in 34338 probably borked this.  Try the below:


diff --git a/Test/V07pcre.ztst b/Test/V07pcre.ztst
index 3c25be2..ddfd3f5 100644
--- a/Test/V07pcre.ztst
+++ b/Test/V07pcre.ztst
@@ -5,6 +5,8 @@
     ZTST_unimplemented="the zsh/pcre module is not available"
     return 0
   fi
+# Load the rest of the builtins
+  zmodload zsh/pcre
   setopt rematch_pcre
 # Find a UTF-8 locale.
   setopt multibyte