Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] jp: fix segfaults during parameter expansion



On Sun, Jan 21, 2018 at 09:43:26AM -0800, Bart Schaefer wrote:
> 
> There's no reason to do both of these changes.  You do the first one if
> you like the "reference used with array" error message, or you do the
> second one if you like the "not an identifier" message.  The second
> one will never take the dupstring() branch if you have done the first.

Noted, I feel like the "not an identifier message", although strange,
is more useful here. That one at least sort of makes sense; the other
"reference used with array" message took a few minutes digging
through the source to even figure out what that even meant
in normal context.

When i send updated patches, what's the best format? A new email after
a separate response mail, or as a single email with the response
at the bottom (or some other third option, maybe)?

Sending this one as its own separate mail for now.

-- 
Joey Pabalinas

Attachment: signature.asc
Description: PGP signature



Messages sorted by: Reverse Date, Date, Thread, Author