Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

[PATCH 13/25] General cleanup.



From: Doron Behar <doron.behar@xxxxxxxxx>

---
 Completion/Unix/Command/_luarocks | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/Completion/Unix/Command/_luarocks b/Completion/Unix/Command/_luarocks
index c1a47773b..d73a84d2a 100644
--- a/Completion/Unix/Command/_luarocks
+++ b/Completion/Unix/Command/_luarocks
@@ -38,21 +38,16 @@ __luarocks_deps_mode(){
 	_describe 'dependencies mode' modes
 }
 # }}}
-# {{{ helper: versions of an external rock
+# {{{ helper: versions of an external rock or nothing for rockspec file
 __luarocks_rock_version(){
 	for i in {2..${#build_command_options[@]}}; do
 		if [[ ! -z "${words[$i]}" && ! "${words[$i]}" =~ '^-' && ! -f "${words[$i]}" ]]; then
-			# TODO: complete with optional versions
 			_message -e "version for rock ${words[$i]}"
 			return
 		fi
 	done
 }
 # }}}
-# {{{ helper: list of libraries that C files need to link to
-__luarocks_c_libs(){
-}
-# }}}
 # {{{ helper: lua versions
 __luarocks_lua_versions(){
 	_values -s , 5.3 5.2 5.1
@@ -76,7 +71,7 @@ ___luarocks_installed_rocks_cache_policy(){
 # }}}
 # {{{ helper: installed rocks
 __luarocks_installed_rocks(){
-	local update_policy ret=1
+	local update_policy
 	zstyle -s ":completion:${curcontext}:" cache-policy update_policy
 	if [[ -z "$update_policy" ]]; then
 		zstyle ":completion:${curcontext}:" cache-policy ___luarocks_installed_rocks_cache_policy
@@ -180,7 +175,7 @@ _luarocks_build(){
 # }}}
 # {{{ `config` command
 # arguments:
-# - must: VAR=VALUE
+# - must: option
 local config_command_options=(
 	'--lua-incdir[Path to Lua header files]'
 	'--lua-libdir[Path to Lua library files]'
@@ -393,7 +388,7 @@ local write_rockspec_command_options=(
 	'--lua-version=[Supported Lua versions]:LUA_VER:__luarocks_lua_versions'
 	'--rockspec-format=[Rockspec format version, such as "1.0" or "1.1"]:VER: '
 	'--tag=[Tag to use. Will attempt to extract version number from it]:TAG:__git_tag'
-	'--lib=[A comma-separated list of libraries that C files need to link to]:__luarocks_c_libs'
+	'--lib=[A comma-separated list of libraries that C files need to link to]:'
 )
 _luarocks_write_rockspec(){
 }
-- 
2.17.0



Messages sorted by: Reverse Date, Date, Thread, Author