Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH v3 2/3] builtins: kill: Add `kill ''` regression test with explicit sigspec

X-seq: zsh-workers 45458
From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
To: Chris Down <chris@xxxxxxxxxxxxxx>
Subject: Re: [PATCH v3 2/3] builtins: kill: Add `kill ''` regression test with explicit sigspec
Date: Tue, 18 Feb 2020 13:04:06 +0000
Cc: zsh-workers@xxxxxxx
In-reply-to: <9cd0633db0d2e6d5238c98426bf18a0946e81c60.1581952273.git.chris@chrisdown.name>
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
References: <c02a0a26bf4c82b1e227053337a4c71525504574.1581952273.git.chris@chrisdown.name> <9cd0633db0d2e6d5238c98426bf18a0946e81c60.1581952273.git.chris@chrisdown.name>

Good morning Chris,

Chris Down wrote on Mon, 17 Feb 2020 10:12 -0500:
> The version without a sigspec can't be added yet because it would still
> kill the test runner even in expected-to-fail mode, see workers/45449
> for discussion. For the same reason, we use a signal which is non-fatal
> by default and unlikely to be sent by someone else, SIGURG, to do the
> expected-to-fail case prior to the fix.

Do you consider the rationale for using SIGURG important enough to be
added in a code comment?

I've pushed this series to master with prose changes only.

Thanks a lot!

Daniel

Follow-Ups:
- Re: [PATCH v3 2/3] builtins: kill: Add `kill ''` regression test with explicit sigspec
  - From: Chris Down

References:
- [PATCH v3 1/3] builtins: kill: Add basic test suite
  - From: Chris Down
- [PATCH v3 2/3] builtins: kill: Add `kill ''` regression test with explicit sigspec
  - From: Chris Down

Messages sorted by: Reverse Date, Date, Thread, Author