Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH v3 2/3] builtins: kill: Add `kill ''` regression test with explicit sigspec


Daniel Shahaf writes:
Chris Down wrote on Mon, 17 Feb 2020 10:12 -0500:
The version without a sigspec can't be added yet because it would still
kill the test runner even in expected-to-fail mode, see workers/45449
for discussion. For the same reason, we use a signal which is non-fatal
by default and unlikely to be sent by someone else, SIGURG, to do the
expected-to-fail case prior to the fix.

Do you consider the rationale for using SIGURG important enough to be
added in a code comment?

Hmm, when I was considering whether to write it in the commit message or in the file, my rationale was that after 3/3 we're still going to end up killing the whole process group if it regresses, so likely the only people who'd run into this distinction are those doing `git bisect`. As such the commit message seemed the best place to me. I'm neutral though :-)

I've pushed this series to master with prose changes only.

Thank you, and thanks for your diligent review!


Messages sorted by: Reverse Date, Date, Thread, Author