Re: zle: vi mode: wrong undo handling on fresh lines

[Peter Stephenson <p.stephenson@xxxxxxxxxxx>]

On Thu, 30 Jan 2014 23:51:10 +0900
"Jun T." <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
> This is my "trial" to (somewhat) improve the behavior of 'undo' after
> completion.  The patch below is against (git-HEAD)+(patch in 32314 by
> Oliver Kiddle).

Thanks.

> The change in zle_tricky.c is to start a new undo-block when entering a
> completion.
> 
> The change in zle_main.c is to make 'undo' no to bring back the suffix added
> by completion but erased when going back to the command mode.
> (This will also change the behavior in emacs-mode.)
> 
> Or these are just matter of preference and must not be hard-coded but
> configurable?

I think this is probably OK generally since it seems to reflect fairly
intuitively what counts as a change.  With the ability to undo
repeatedly I certainly don't think this needs any more configuration.

It looks very much along the right lines, but I'll let the others
comment.

pws