Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: zle: vi mode: wrong undo handling on fresh lines

On 29 Jan, I wrote:
> +++ b/Src/Zle/zle_tricky.c
> @@ -611,8 +611,7 @@ docomplete(int lst)

> -    if (undoing)
> -	setlastline();
> +    setlastline();

I have a widget that adds text to LBUFFER and invokes completion.
The text added to LBUFFER can't be undone with this change and with
emacs mode, the problem was there before. I think this line should just
be removed as it doesn't make much sense anyway.

It was added in workers/8590 (a reply to 8574). Removing it doesn't seem
to cause problems that I can find though the examples in 8574 seem
broken in other ways.


diff --git a/Src/Zle/zle_tricky.c b/Src/Zle/zle_tricky.c
index a12fa08..3c7cff9 100644
--- a/Src/Zle/zle_tricky.c
+++ b/Src/Zle/zle_tricky.c
@@ -611,7 +611,6 @@ docomplete(int lst)
     active = 1;
     comprecursive = 0;
-    setlastline();
     /* From the C-code's point of view, we can only use compctl as a default
      * type of completion. Load it if it hasn't been loaded already and

Messages sorted by: Reverse Date, Date, Thread, Author