Zsh Mailing List Archive
Messages sorted by:
Re: mikachu/badarrays (Re: Valgrind testing, ideas)
- X-seq: zsh-workers 41195
- From: Mikael Magnusson <mikachu@xxxxxxxxx>
- To: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- Subject: Re: mikachu/badarrays (Re: Valgrind testing, ideas)
- Date: Thu, 1 Jun 2017 23:22:20 +0200
- Cc: zsh workers <zsh-workers@xxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1zAQbYyDo8zgH3ifsuDipv+En5+j6JcTsScHL/gFSSE=; b=Ihi0tCuS042+rijyZR8+gd/QVHOqim0/NGOfYw2AtCyu4mi+MnG0UO5afg2YHQOJeR af5UkaIFrp2hwNwI0+lQ3Gu4jdT5TboH43W50GDP6a/bueRLfvHnyGpjYa0D+98kthmu sIqGrDfKjYsVVEhiOaQnrlHL+i2MptDfkbV63ZkQpKSnKVDLVaNsKpkpb4sLGvG2RXPq 8u/6yk3QC1CXWRDZOzXxy7zLYSTjpi/dxbqVYbzmcUCMwYWvG0ro0JQh0NfSKy03oqUF /KPVw2sW/szTK3LJZ8bkEoBUIbnp3YDgC4u5wzo+phrNhjEAO0I4n8jy0iCL/d76PtTK v6bg==
- In-reply-to: <170530224728.ZM25709@torch.brasslantern.com>
- List-help: <mailto:firstname.lastname@example.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:email@example.com>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <etPan.5927b758.12200854.1a9@MacMini.local> <170528124337.ZM9444@torch.brasslantern.com> <CAHYJk3QEJ__xMgiMNS8O8yLaPaF_XeYmwYTRaG-Dfrba4cmNWg@mail.gmail.com> <170530224728.ZM25709@torch.brasslantern.com>
On Wed, May 31, 2017 at 7:47 AM, Bart Schaefer
> On May 29, 3:21pm, Mikael Magnusson wrote:
> } Well, it never worked in the first place, that's why i put "bad" in
> } the name. It's basically just a documentation of the places I found
> } that would need to be updated to use a cached length value, but since
> } it doesn't work I guess I didn't find all of them, or I misunderstood
> } some parts of the code that I changed...
> It also appears we've run out of bits for PM_CACHELEN and PM_CHECKEN,
> the 19 and 20 bit positions are are now occupied by PM_DONTIMPORT_SUID
> and PM_SINGLE, though I suppose PM_KSHSTORED and PM_ZSHSTORED could do
> double duty as they won't apply to arrays and functions at once.
> With respect to "it doesn't work" -- in commits f4ab07b4 and b7c2ddf6
> you say you're adding typeset -C and typeset -c to control PM_CACHELEN
> and PM_CHECKLEN but looking at the diffs you only added the argument
> parsing; I can't find anywhere that PM_CACHELEN or PM_CHECKLEN are ever
> assigned to the parameter flags?
> I believe I've now merged params.c ... I tried forcing both of the new
> flags on for non-special PM_ARRAY params in createparam(), and all tests
> seem to pass except those involving the $match array, which implies one
> of us did something wrong in setarrvalue() for post_assignment_length.
> I think.
The existing code probably does something fun like assigning these
flags based on the order of flags in the TYPESET_OPTSTR define. If you
don't use typeset -c/-C for anything, then none of the new code should
be activated and it is indeed expected that things would work.
Messages sorted by: