Zsh Mailing List Archive
Messages sorted by:
Re: mikachu/badarrays (Re: Valgrind testing, ideas)
- X-seq: zsh-workers 41196
- From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- To: zsh workers <zsh-workers@xxxxxxx>
- Subject: Re: mikachu/badarrays (Re: Valgrind testing, ideas)
- Date: Thu, 1 Jun 2017 14:38:08 -0700
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=g+tzxRDvkOuVNj7suRdJ9L8i4agEJoc3nbVwhIwz12U=; b=AWAti7fwO3OdEpHHE5qDBQkvIhWzpYxzIybtXM4+1E05TrPcKXzpZvrT8c+y+do2cx YhnkkGcAURsGTb4zWu4G09PwWKEEpM8Q//iMMamVbnuGnD9C0CTb/COyDWEHTEX+Mtlw MzeQB36j77d+frKFUGsn8QyzP2qH/qhcE13iL3dn6EebVrVIUQrZJEyGOsb8jOUuVsDo N/2OFyguBF1+ZbehzwrVmUJrIviDC1F4+iRGaGlaoQLPSsxF4wE0WBYBsGgXdMMjj3H3 cl4EehoyjQRp+V9ahFaJbHfJzhBlo2jYziiyvOoaJHUd4aUZI/Mey8Gx9JbHCdGTlGW/ 1Hig==
- In-reply-to: <CAHYJk3Tj0xynRk+cRsMosgnzwiv==VH8A6sTyjHf38dDV36Ong@mail.gmail.com>
- List-help: <mailto:email@example.com>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:firstname.lastname@example.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <etPan.5927b758.12200854.1a9@MacMini.local> <170528124337.ZM9444@torch.brasslantern.com> <CAHYJk3QEJ__xMgiMNS8O8yLaPaF_XeYmwYTRaG-Dfrba4cmNWg@mail.gmail.com> <170530224728.ZM25709@torch.brasslantern.com> <CAHYJk3Tj0xynRk+cRsMosgnzwiv==VH8A6sTyjHf38dDV36Ong@mail.gmail.com>
On Jun 1, 11:22pm, Mikael Magnusson wrote:
} Subject: Re: mikachu/badarrays (Re: Valgrind testing, ideas)
} On Wed, May 31, 2017 at 7:47 AM, Bart Schaefer
} <schaefer@xxxxxxxxxxxxxxxx> wrote:
} > It also appears we've run out of bits for PM_CACHELEN and PM_CHECKEN,
} > the 19 and 20 bit positions are are now occupied by PM_DONTIMPORT_SUID
} > and PM_SINGLE, though I suppose PM_KSHSTORED and PM_ZSHSTORED could do
} > double duty as they won't apply to arrays and functions at once.
} The existing code probably does something fun like assigning these
} flags based on the order of flags in the TYPESET_OPTSTR define.
Indeed, that's the case. So that means it's now essentially impossible
to add any more options to typeset, because bit positions 19+ are used
by values that must be assigned in the IPDEF(...) structs for params
used/set by the shell. In other words adding "cC" at the end of the
TYPEST_OPTSTR is now going to be broken by other things, unless we
add some special-case code.
} If you don't use typeset -c/-C for anything, then none of the new code
} should be activated and it is indeed expected that things would work.
As I mentioned:
} > I tried forcing both of the new
} > flags on for non-special PM_ARRAY params in createparam()
So they were getting used everywhere, even without "typeset -c". What
remained broken after that was the code that resizes an existing array.
Messages sorted by: